[PATCHv9 01/15] submodule: add lwIP as git submodule

[Tom Rini]

On Wed, Sep 20, 2023 at 07:03:07PM -0600, Simon Glass wrote:
> Hi Maxim,
> 
> On Thu, 14 Sept 2023 at 10:20, Maxim Uvarov <maxim.uvarov at linaro.org> wrote:
> >
> > add external lwIP library as a git submodule.
> 
> Oh dear...what is the motivation for using a submodule?

That we don't have a better alternative.  Using "git subtree" has it's
own problems and won't make things overall better.

> Our current stack is nicely integrated into U-Boot. This would make
> moving between development branches much more painful.

It really shouldn't matter in that case.  Unless you're trying out a new
lwip upstream commit, nothing changes in there.  It _may_ mean that if
we want to update lwip it's not something that can be staged first in
the -next branch but instead something to pull in just after release,
but I'd need to see how smart or not git is today about things like
that.

> I would much prefer that we bring in the necessary code, and that you
> send a patch every 3 months or so to deal with updates, making sure
> there are no code-size regressions.

And I much prefer something that will make sure that we don't start
making changes in upstream code and diverging.  I don't think there's a
mechanic short of submodule that will do that for us.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20230921/afad64b7/attachment.sig>