[PATCH] arm: mvebu: sata_mv: Add bootstd hook to enable sata_bootdev

[Tony Dinh]

Hi Simon,

On Sun, Sep 24, 2023 at 1:40 PM Simon Glass <sjg at chromium.org> wrote:
>
> Hi Tony,
>
> On Tue, 5 Sept 2023 at 23:23, Tony Dinh <mibodhi at gmail.com> wrote:
> >
> > Add hook in sata_mv probe to enable bootstd bootdev.
> >
> > Note: bootdev_setup_for_sibling_blk() invocation is a noop if bootsd is
> > not enabled for ahci sata yet.
> >
> > Signed-off-by: Tony Dinh <mibodhi at gmail.com>
> > ---
> >
> >  drivers/ata/sata_mv.c | 8 +++++++-
> >  1 file changed, 7 insertions(+), 1 deletion(-)
> >
>
> Reviewed-by: Simon Glass <sjg at chromium.org>
>
> But please see below
>
> > diff --git a/drivers/ata/sata_mv.c b/drivers/ata/sata_mv.c
> > index 18c7a66db1..55a5365b5a 100644
> > --- a/drivers/ata/sata_mv.c
> > +++ b/drivers/ata/sata_mv.c
> > @@ -34,6 +34,7 @@
> >  #include <common.h>
> >  #include <ahci.h>
> >  #include <blk.h>
> > +#include <bootdev.h>
> >  #include <cpu_func.h>
> >  #include <dm.h>
> >  #include <log.h>
> > @@ -1104,6 +1105,12 @@ static int sata_mv_probe(struct udevice *dev)
> >                         /* TODO: undo create */
> >                         continue;
> >
> > +               ret = bootdev_setup_for_sibling_blk(blk, "sata_bootdev");
> > +               if (ret) {
> > +                       printf("%s: Failed to create bootdev\n", __func__);
> > +                       continue;
> > +               }
> > +
> >                 /* If we got here, the current SATA port was probed
> >                  * successfully, so set the probe status to successful.
> >                  */
> > @@ -1116,7 +1123,6 @@ static int sata_mv_probe(struct udevice *dev)
> >  static int sata_mv_scan(struct udevice *dev)
> >  {
> >         /* Nothing to do here */
> > -
>
> You should leave this - the style is to put a newline before the final
> return in a function.

Thanks,
Tony

>
> >         return 0;
> >  }
> >
> > --
> > 2.39.2
> >
>
> Regards,
> Simon