[PATCH v2 3/3] trace: Fix alignment logic in flyrecord header

Michal Simek michal.simek at amd.com
Mon Sep 25 15:38:43 CEST 2023



On 9/25/23 15:10, Simon Glass wrote:
> Hi Michal,
> 
> On Mon, 25 Sept 2023 at 00:06, Michal Simek <michal.simek at amd.com> wrote:
>>
>> Hi Simon,
>>
>>
>> On 9/23/23 20:13, Simon Glass wrote:
>>> Current alignment which is using 16 bytes is not correct in connection to
>>> trace_clocks description and it's length.
>>> That's why use start_addr variable and record proper size based on used
>>> entries.
>>>
>>> Fixes: be16fc81b2ed ("trace: Update proftool to use new binary format").
>>> Signed-off-by: Michal Simek <michal.simek at amd.com>
>>> Reviewed-by: Simon Glass <sjg at chromium.org>
>>> ---
>>>
>>> Changes in v2:
>>> - s/start_addr/start_ofs/g'
>>>
>>>    tools/proftool.c | 31 +++++++++++++++++++++++++++++--
>>>    1 file changed, 29 insertions(+), 2 deletions(-)
>>>
>>> Applied to u-boot-dm, thanks!
>>
>> FYI: I have merged it to my tree and already sent pull request to Tom.
>> Without it I couldn't pass CI loop to get all reviewed features in.
>>
>> https://lore.kernel.org/all/ab72c480-e9f8-416e-adf5-726f7d40c4f5@amd.com/
> 
> Ah OK, well that's fine. It was in my patchwork queue still, which
> suggests that the patches were not set to 'applied'?

I am not using patchwork. But I expect my reply to cover letter was recorded there.

Thanks,
Michal


More information about the U-Boot mailing list