[PATCH 05/32] spl: mx6: powerpc: Drop the condition on timer_init()

[Christophe Leroy]

Le 26/09/2023 à 13:37, Simon Glass a écrit :
> Hi,
> 
> On Wed, 20 Sept 2023 at 19:03, Simon Glass <sjg at chromium.org> wrote:
>>
>> Hi Tom,
>>
>> On Thu, 31 Aug 2023 at 11:51, Tom Rini <trini at konsulko.com> wrote:
>>>
>>> On Wed, Aug 30, 2023 at 12:04:36PM -0600, Simon Glass wrote:
>>>
>>>> It doesn't make sense to have some boards do this differently. Drop the
>>>> condition in the hope that the maintainers can figure out any run-time
>>>> problems.
>>>>
>>>> Signed-off-by: Simon Glass <sjg at chromium.org>
>>>> ---
>>>>
>>>>   common/spl/spl.c | 6 ------
>>>>   1 file changed, 6 deletions(-)
>>>>
>>>> diff --git a/common/spl/spl.c b/common/spl/spl.c
>>>> index 78db9ef5318..3f513b0563a 100644
>>>> --- a/common/spl/spl.c
>>>> +++ b/common/spl/spl.c
>>>> @@ -766,13 +766,7 @@ void board_init_r(gd_t *dummy1, ulong dummy2)
>>>>                if (spl_init())
>>>>                        hang();
>>>>        }
>>>> -#if !defined(CONFIG_PPC) && !defined(CONFIG_ARCH_MX6)
>>>> -     /*
>>>> -      * timer_init() does not exist on PPC systems. The timer is initialized
>>>> -      * and enabled (decrementer) in interrupt_init() here.
>>>> -      */
>>>>        timer_init();
>>>> -#endif
>>>
>>> PowerPC might be a little tricky, did qemu-ppce500 run?  And please
>>> reach out to some of the iMX folks instead of just dropping this and
>>> hoping it works.
>>
>> Yes, CI passes.
>>
>> +Christophe Leroy
>> +Marek Behún
>>
>> PowerPC people, does this look OK?
> 
> Are there any active maintainers for PowerPC?
> 
> Apart from this patch, is there any word on the DM_SERIAL migration?
> 

The three powerpc boards I maintain (ref. boards/cssi/MAINTAINERS) all 
select DM_SERIAL:

configs/CMPC885_defconfig:CONFIG_DM_SERIAL=y
configs/CMPCPRO_defconfig:CONFIG_DM_SERIAL=y
configs/MCR3000_defconfig:CONFIG_DM_SERIAL=y

Christophe