[PATCH] mailbox: k3-sec-proxy: fix error handling for missing scfg in FDT

Nishanth Menon nm at ti.com
Tue Sep 26 15:57:40 CEST 2023


On 14:42-20230926, Matthias Schiffer wrote:
> The wrong field was checked.
> 
> Fixes: f9aa41023bd9 ("mailbox: Introduce K3 Secure Proxy Driver")
> Signed-off-by: Matthias Schiffer <matthias.schiffer at ew.tq-group.com>
> ---
>  drivers/mailbox/k3-sec-proxy.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mailbox/k3-sec-proxy.c b/drivers/mailbox/k3-sec-proxy.c
> index 815808498f2..27072610462 100644
> --- a/drivers/mailbox/k3-sec-proxy.c
> +++ b/drivers/mailbox/k3-sec-proxy.c
> @@ -326,7 +326,7 @@ static int k3_sec_proxy_of_to_priv(struct udevice *dev,
>  	}
>  
>  	spm->scfg = devfdt_get_addr_name(dev, "scfg");
> -	if (spm->rt == FDT_ADDR_T_NONE) {
> +	if (spm->scfg == FDT_ADDR_T_NONE) {
>  		dev_err(dev, "No reg property for Secure Cfg base\n");
>  		return -EINVAL;
>  	}

Uggh.. Thanks for catching this.

Reviewed-by: Nishanth Menon <nm at ti.com>
-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D


More information about the U-Boot mailing list