bootstd: Scanning for USB bootflow will remove existing SCSI bootflow

[Tony Dinh]

Hi Simon,

On Tue, Sep 26, 2023 at 4:37 AM Simon Glass <sjg at chromium.org> wrote:
>
> Hi Tony,
>
> On Mon, 25 Sept 2023 at 14:02, Tony Dinh <mibodhi at gmail.com> wrote:
> >
> > Hi Simon,
> >
> > Here is an observation during testing the bootflow command.
> >
> > If there is a SCSI bootflow, scanning for USB bootflow will remove that existing
> > SCSI bootflow. To bring it back, I scanned for SCSI bootflow again, and it was
> > back to normal. Perhaps there is some kind of indexing problem?
>
> Yes that's right. The 'botflow scan' command is not additive. The
> first thing it does is removing existing bootflows.

Thanks for clarifying that. I assumed it is additive, because the
existing USB bootflow was not removed when I did a "bootflow scan
scsi" immediately after (see the end of the log).

Thanks,
Tony

>
> >
> > Please see the log below after the break.
> >
> > All the best,
> > Tony
> >
> > ===============
> > <BEGIN LOG>
> >
> > U-Boot 2023.10-rc4-tld-1-00044-g9c21b2a350-dirty (Sep 18 2023 - 12:16:59 -0700)
> > Thecus N2350
> >
> > <snip>
> >
> > N2350 > env def -a
> > ## Resetting to default environment
> >
> > N2350 > bootflow scan scsi
> > pcie0.0: Link down
> > pcie1.0: Link down
> > scanning bus for devices...
> > SATA link 0 timeout.
> > Target spinup took 0 ms.
> > AHCI 0001.0000 32 slots 2 ports 6 Gbps 0x3 impl SATA mode
> > flags: 64bit ncq led only pmp fbss pio slum part sxs
> >   Device 0: (1:0) Vendor: ATA Prod.: ST750LX003-1AC15 Rev: SM12
> >             Type: Hard Disk
> >             Capacity: 715404.8 MB = 698.6 GB (1465149168 x 512)
> > ** File not found /boot/boot.bmp **
> >
> > N2350 > bootflow l
> > Showing all bootflows
> > Seq  Method       State   Uclass    Part  Name                      Filename
> > ---  -----------  ------  --------  ----  ------------------------
> > ----------------
> >   0  script       ready   scsi         1  ahci_scsi.id1lun0.bootdev
> > /boot/boot.scr
> > ---  -----------  ------  --------  ----  ------------------------
> > ----------------
> > (1 bootflow, 1 valid)
> >
> > N2350 > bootflow scan usb
> > Bus usb at 58000: USB EHCI 1.00
> > Bus usb3 at f0000: MVEBU XHCI INIT controller @ 0xf10f4000
> > Register 2000120 NbrPorts 2
> > Starting the controller
> > USB XHCI 1.00
> > Bus usb3 at f8000: MVEBU XHCI INIT controller @ 0xf10fc000
> > Register 2000120 NbrPorts 2
> > Starting the controller
> > USB XHCI 1.00
> > scanning bus usb at 58000 for devices... 1 USB Device(s) found
> > scanning bus usb3 at f0000 for devices... 1 USB Device(s) found
> > scanning bus usb3 at f8000 for devices... 2 USB Device(s) found
> > ** File not found /boot/boot.bmp **
> >
> > N2350 > bootflow l
> > Showing all bootflows
> > Seq  Method       State   Uclass    Part  Name                      Filename
> > ---  -----------  ------  --------  ----  ------------------------
> > ----------------
> >   0  script       ready   usb_mass_    1  usb_mass_storage.lun0.boo
> > /boot/boot.scr
> > ---  -----------  ------  --------  ----  ------------------------
> > ----------------
> > (1 bootflow, 1 valid)
> >
> > N2350 > bootflow scan scsi
> > ** File not found /boot/boot.bmp **
> > ** File not found /boot/boot.bmp **
> >
> > N2350 > bootflow l
> > Showing all bootflows
> > Seq  Method       State   Uclass    Part  Name                      Filename
> > ---  -----------  ------  --------  ----  ------------------------
> > ----------------
> >   0  script       ready   scsi         1  ahci_scsi.id1lun0.bootdev
> > /boot/boot.scr
> >   1  script       ready   usb_mass_    1  usb_mass_storage.lun0.boo
> > /boot/boot.scr
> > ---  -----------  ------  --------  ----  ------------------------
> > ----------------
> > (2 bootflows, 2 valid)
> >
> > <END LOG>
>
> Regards,
> Simon