[PATCH 1/7] net: dwc_eth_qos: Drop unused rx_pkt from eqos_priv

Kever Yang kever.yang at rock-chips.com
Wed Sep 27 05:00:18 CEST 2023


On 2023/8/7 08:08, Jonas Karlman wrote:
> rx_pkt is allocated and not used for anything, remove it.
>
> Signed-off-by: Jonas Karlman <jonas at kwiboo.se>
Reviewed-by: Kever Yang <kever.yang at rock-chips.com>

Thanks,
- Kever
> ---
>   drivers/net/dwc_eth_qos.c | 11 -----------
>   drivers/net/dwc_eth_qos.h |  1 -
>   2 files changed, 12 deletions(-)
>
> diff --git a/drivers/net/dwc_eth_qos.c b/drivers/net/dwc_eth_qos.c
> index 1e92bd9ca9c0..555eaee3bbc3 100644
> --- a/drivers/net/dwc_eth_qos.c
> +++ b/drivers/net/dwc_eth_qos.c
> @@ -1314,22 +1314,12 @@ static int eqos_probe_resources_core(struct udevice *dev)
>   	}
>   	debug("%s: rx_dma_buf=%p\n", __func__, eqos->rx_dma_buf);
>   
> -	eqos->rx_pkt = malloc(EQOS_MAX_PACKET_SIZE);
> -	if (!eqos->rx_pkt) {
> -		debug("%s: malloc(rx_pkt) failed\n", __func__);
> -		ret = -ENOMEM;
> -		goto err_free_rx_dma_buf;
> -	}
> -	debug("%s: rx_pkt=%p\n", __func__, eqos->rx_pkt);
> -
>   	eqos->config->ops->eqos_inval_buffer(eqos->rx_dma_buf,
>   			EQOS_MAX_PACKET_SIZE * EQOS_DESCRIPTORS_RX);
>   
>   	debug("%s: OK\n", __func__);
>   	return 0;
>   
> -err_free_rx_dma_buf:
> -	free(eqos->rx_dma_buf);
>   err_free_tx_dma_buf:
>   	free(eqos->tx_dma_buf);
>   err_free_descs:
> @@ -1348,7 +1338,6 @@ static int eqos_remove_resources_core(struct udevice *dev)
>   
>   	debug("%s(dev=%p):\n", __func__, dev);
>   
> -	free(eqos->rx_pkt);
>   	free(eqos->rx_dma_buf);
>   	free(eqos->tx_dma_buf);
>   	eqos_free_descs(eqos->rx_descs);
> diff --git a/drivers/net/dwc_eth_qos.h b/drivers/net/dwc_eth_qos.h
> index a6b719af809f..06a082da72ef 100644
> --- a/drivers/net/dwc_eth_qos.h
> +++ b/drivers/net/dwc_eth_qos.h
> @@ -273,7 +273,6 @@ struct eqos_priv {
>   	unsigned int desc_per_cacheline;
>   	void *tx_dma_buf;
>   	void *rx_dma_buf;
> -	void *rx_pkt;
>   	bool started;
>   	bool reg_access_ok;
>   	bool clk_ck_enabled;


More information about the U-Boot mailing list