[PATCH v1 3/3] arm: npcm8xx: support dcache off

[Tom Rini]

On Thu, Sep 28, 2023 at 08:49:23AM +0800, Jim Liu wrote:
> Hi Tom
> 
> Thanks for the quick review.
> 
> if we set the CONFIG_SYS_DCACHE_OFF the  armv8 will build error.
> So we added a workaround for our bmc uboot.
> 
> the error message as below:
> 
> CONFIG_SYS_DCACHE_OFF can't be enabled on armv8, or the following
> build error would happen.
> 
> arch/arm/cpu/armv8/cpu.o: in function `cleanup_before_linux':
> arch/arm/cpu/armv8/cpu.c:60: undefined reference to `icache_disable'
> arch/arm/cpu/armv8/cpu.c:68: undefined reference to `dcache_disable'
> arch/arm/cpu/armv8/cpu.c:69: undefined reference to `invalidate_dcache_all'

OK, so you need
https://patchwork.ozlabs.org/project/uboot/patch/20230811054228.3721455-1-bhupesh.sharma@linaro.org/
to be applied, as-is, yes? Thanks!

> 
> Best regards,
> Jim
> 
> On Tue, Sep 26, 2023 at 9:48 PM Tom Rini <trini at konsulko.com> wrote:
> >
> > On Tue, Sep 26, 2023 at 04:56:50PM +0800, Jim Liu wrote:
> >
> > > do not enable dcache by setting CONFIG_SYS_NPCM_DCACHE_OFF=y
> > >
> > > Signed-off-by: Jim Liu <JJLIU0 at nuvoton.com>
> > > ---
> > >  arch/arm/mach-npcm/npcm8xx/Kconfig |  4 ++++
> > >  arch/arm/mach-npcm/npcm8xx/cpu.c   | 12 +++++++++++-
> > >  2 files changed, 15 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/arch/arm/mach-npcm/npcm8xx/Kconfig b/arch/arm/mach-npcm/npcm8xx/Kconfig
> > > index 5f4a0506dc..163e7e7d48 100644
> > > --- a/arch/arm/mach-npcm/npcm8xx/Kconfig
> > > +++ b/arch/arm/mach-npcm/npcm8xx/Kconfig
> > > @@ -6,6 +6,10 @@ config SYS_CPU
> > >  config SYS_SOC
> > >       default "npcm8xx"
> > >
> > > +config SYS_NPCM_DCACHE_OFF
> > > +     bool "Do not enable dcache"
> > > +     default n
> > > +
> > >  config TARGET_ARBEL_EVB
> > >       bool "Arbel Evaluation Board"
> > >       help
> >
> > Why do we need a new Kconfig option here on top of the existing generic
> > ones to control cache?
> >
> > --
> > Tom

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20230928/df7c6c48/attachment.sig>