[PATCH] spl: Jump to image at end of board_init_r

Heinrich Schuchardt xypron.glpk at gmx.de
Fri Sep 29 10:02:47 CEST 2023


On 9/29/23 09:55, Ferass El Hafidi wrote:
> Hi Heinrich,
>
> On Fri Sep 29, 2023 at 2:57 AM CEST, Heinrich Schuchardt wrote:
>> In SPL we are fighting for every byte of binary size.
>>
>> What is the impact of this change on the code size?
>>
>> I would expect that your increasing it; especially if only one of the
>> CONFIG_OPTIONS is enabled.
>>
>> If so, NAK to this patch despite all elegance.
>
> Would you prefer removing `spl_board_prepare_for_boot()` instead?
> A handful of boards make use for it so I'd say this is a bug if it never
> gets ran on those.
>
> Or would it be better if it was enabled with a CONFIG_ option?

We should understand the implications of your patch on the code size. If
it leads to binary code growth, we should evaluate alternatives.

Best regards

Heinrich


More information about the U-Boot mailing list