[PATCH v2 01/17] dm: usb: udc: Factor out plain udevice handler functions

[Marek Vasut]

On 9/27/23 15:59, Miquel Raynal wrote:
> Hi Marek,

Hi,

> miquel.raynal at bootlin.com wrote on Fri, 22 Sep 2023 12:00:12 +0200:
> 
>> Hi Marek,
>>
>> I'm answering here as there is no cover letter. Just to let you know
>> I'm still concerned by the series and want to test it but did not had
>> the time to do so recently. Hopefully next week.
> 
> The series looks good to me and works as well on a Beagle Bone Black
> with no visible functional changes regarding the use of the UDC. The
> whole series is:
> 
> Tested-by: Miquel Raynal <miquel.raynal at bootlin.com>
> 
> By the way, following your initial series there have been three
> followup patches trying to improve a little bit the doc, one got merged
> and two others were delegated to you:
> https://patchwork.ozlabs.org/project/uboot/list/?series=367635
> 
> They are almost 2 months old now, would you mind acking or merging
> them so both your initial USB gadget rework and the additional
> (related) doc can be in the same release please?

Can you resend those and CC this mail address ?

That said, 1/2 should be in some sort of README instead, and the 'dm 
tree' command depends on CMD_DM=y .

The usb_gadget_probe_driver() is code synchronized from kernel, you 
likely want to add any such clarification to 
usb_gadget_register_driver() . That said, the 
usb_gadget_register_driver() should be reworked into some new functions, 
which takes UDC controller *udevice pointer to avoid this binding 
heuristics.