[PATCH 10/19] rockchip: rk35xx: Sort soc u-boot.dtsi alphabetically
Quentin Schulz
quentin.schulz at theobroma-systems.com
Tue Apr 2 12:23:30 CEST 2024
Hi Jonas,
On 3/29/24 20:01, Jonas Karlman wrote:
> Sort nodes and props in RK356x/RK3588 u-boot.dtsi alphabetically, nodes
> is sorted by reg addr then by alphabetical order.
>
> This has no intended change beside sorting existing nodes and removing
> a duplicated usbdpphy0_grf node.
>
> Signed-off-by: Jonas Karlman <jonas at kwiboo.se>
> ---
> arch/arm/dts/rk356x-u-boot.dtsi | 100 +++++++++++++++----------------
> arch/arm/dts/rk3588s-u-boot.dtsi | 71 ++++++++++------------
> 2 files changed, 83 insertions(+), 88 deletions(-)
>
> diff --git a/arch/arm/dts/rk356x-u-boot.dtsi b/arch/arm/dts/rk356x-u-boot.dtsi
> index 05367216e118..a0c630326217 100644
> --- a/arch/arm/dts/rk356x-u-boot.dtsi
> +++ b/arch/arm/dts/rk356x-u-boot.dtsi
> @@ -17,8 +17,8 @@
> };
>
> dmc: dmc {
> - compatible = "rockchip,rk3568-dmc";
> bootph-all;
> + compatible = "rockchip,rk3568-dmc";
This doesn't follow the kernel's DT coding style:
https://www.kernel.org/doc/html/latest/devicetree/bindings/dts-coding-style.html#order-of-properties-in-device-node
[...]
> diff --git a/arch/arm/dts/rk3588s-u-boot.dtsi b/arch/arm/dts/rk3588s-u-boot.dtsi
> index 233eb79d9ba2..e4171bd24d2a 100644
> --- a/arch/arm/dts/rk3588s-u-boot.dtsi
> +++ b/arch/arm/dts/rk3588s-u-boot.dtsi
> @@ -15,8 +15,8 @@
> };
>
> dmc {
> - compatible = "rockchip,rk3588-dmc";
> bootph-all;
> + compatible = "rockchip,rk3588-dmc";
Ditto.
Cheers,
Quentin
More information about the U-Boot
mailing list