[PATCH 06/23] image: remove redundant hash includes

Raymond Mao raymond.mao at linaro.org
Wed Apr 17 02:13:53 CEST 2024


Hi Tom,

On Tue, 16 Apr 2024 at 15:19, Tom Rini <trini at konsulko.com> wrote:

> On Tue, Apr 16, 2024 at 12:00:02PM -0700, Raymond Mao wrote:
>
> > Remove the redundant includes of u-boot/md5.h, u-boot/sha1.h,
> > u-boot/sha256.h and u-boot/sha512.h
> >
> > Signed-off-by: Raymond Mao <raymond.mao at linaro.org>
> > ---
> >  boot/image-fit.c | 4 ----
> >  boot/image.c     | 2 --
> >  2 files changed, 6 deletions(-)
>
> Can you please explain how these are redundant? It's not clear, thanks.
>
> Both image.c and image-fit.c include image.h that
includes <u-boot/hash-checksum.h>.
So we don't need to explicitly repeat "#include <u-boot/<digest>.h>" in
both files.

Thanks and regards,
Raymond


More information about the U-Boot mailing list