[PATCH 06/23] image: remove redundant hash includes

Tom Rini trini at konsulko.com
Wed Apr 17 02:19:06 CEST 2024


On Tue, Apr 16, 2024 at 08:13:53PM -0400, Raymond Mao wrote:
> Hi Tom,
> 
> On Tue, 16 Apr 2024 at 15:19, Tom Rini <trini at konsulko.com> wrote:
> 
> > On Tue, Apr 16, 2024 at 12:00:02PM -0700, Raymond Mao wrote:
> >
> > > Remove the redundant includes of u-boot/md5.h, u-boot/sha1.h,
> > > u-boot/sha256.h and u-boot/sha512.h
> > >
> > > Signed-off-by: Raymond Mao <raymond.mao at linaro.org>
> > > ---
> > >  boot/image-fit.c | 4 ----
> > >  boot/image.c     | 2 --
> > >  2 files changed, 6 deletions(-)
> >
> > Can you please explain how these are redundant? It's not clear, thanks.
> >
> > Both image.c and image-fit.c include image.h that
> includes <u-boot/hash-checksum.h>.
> So we don't need to explicitly repeat "#include <u-boot/<digest>.h>" in
> both files.

OK, so lets move this to a prep series patch then please, and then later
<u-boot/hash-checksum.h> can if/as needed get the right headers for
mbedtls or not.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20240416/c261b7ed/attachment.sig>


More information about the U-Boot mailing list