[PATCH v3] doc: document the pwm command
Emil Kronborg
emil.kronborg at protonmail.com
Thu Aug 1 13:19:42 CEST 2024
Hi Quentin,
> On 8/1/24 12:07 PM, Emil Kronborg wrote:
> > [...]
> > +.. SPDX-License-Identifier: GPL-2.0+:
>
> This isn't a valid identifier (spurious ':') I believe.
>
> Also, I would highly suggest to change it to GPL-2.0-or-later which is
> the current naming scheme for the same license, c.f.
> https://spdx.org/licenses/
>
> Otherwise, looking good so with that changed:
>
> Reviewed-by: Quentin Schulz <quentin.schulz at cherry.de>
>
> Thanks!
> Quentin
> On 8/1/24 12:07 PM, Emil Kronborg wrote:
> > [...]
> > +.. SPDX-License-Identifier: GPL-2.0+:
>
> This isn't a valid identifier (spurious ':') I believe.
Hm, I agree that it looks weird, but I think it is fine. There seems to
be a mix of colon and no colon though.
$ git grep "SPDX-License-Identifier: GPL-2.0+:" doc/usage/ | wc -l
48
$ git grep "SPDX-License-Identifier: GPL-2.0+" doc/usage/ | wc -l
114
With that said, GPL-2.0-or-later is most correct to use, and probably
_without_ a trailing colon. In fact, GPL-2.0+ is actually deprecated
according to the link you sent.
Should I send a new patch where the license is fixed?
--
Emil Kronborg
More information about the U-Boot
mailing list