[RFC PATCH 0/4] dm: Duplicate uclass name fix and alias improvements

Simon Glass sjg at chromium.org
Thu Aug 1 16:42:25 CEST 2024


Hi Zixun,

On Wed, 31 Jul 2024 at 07:43, Zixun LI <admin at hifiphile.com> wrote:
>
> Patch 1 is a tentative fix for duplicate uclass name issue met in
> https://lists.denx.de/pipermail/u-boot/2024-July/560189.html
>
> The idea is to use orignal class name only for sequence alias to keep this
> alias function working and rename the class something else.

Can we rename the gadget uclass to usb_gadget or similar, then update
the aliases?

>
> Patch 2 and 3 make "dm tree", "bind" and "unbind" commands to take care
> of alias sequence numbering. As the alias sequence numbering is more
> meanful than uclass index.
>
> Patch 4 is the actual fix for usb gadet class.
>
> There are some situations where uclass index and device sequence number
> are misused which is not convered by this patch set, for example in
> drivers/net/sandbox.c, uclass_get_device() is used which is based on
> uclass index, while in the comments it says "index - The alias index
> (also DM seq number)"
>
> Zixun LI (4):
>   dm: core: Add a way to specify an alt name for alias sequence
>     numbering
>   dm: core: Show device sequence instead in dm_dump_tree()
>   cmd: bind: Use device sequence instead for driver bind/unbind
>   usb: gadget: udc: Fix duplicate uclass name
>
>  cmd/bind.c                          |  4 ++--
>  drivers/core/device.c               |  3 ++-
>  drivers/core/dump.c                 |  2 +-
>  drivers/core/read.c                 |  7 ++++++-
>  drivers/core/uclass.c               | 11 +++++++++--
>  drivers/usb/gadget/udc/udc-uclass.c |  3 ++-
>  include/dm/read.h                   |  9 ++++++++-
>  include/dm/uclass.h                 |  2 ++
>  8 files changed, 32 insertions(+), 9 deletions(-)
>
> --
> 2.45.2
>

Regards,
Simon


More information about the U-Boot mailing list