[PATCH v2] bootstage: Fix out-of-bounds read in reloc_bootstage()

Simon Glass sjg at chromium.org
Thu Aug 1 18:14:37 CEST 2024


Hi Richard,

On Thu, 1 Aug 2024 at 08:48, Richard Weinberger <richard at sigma-star.at> wrote:
>
> Simon,
>
> Am Donnerstag, 1. August 2024, 16:42:14 CEST schrieb Simon Glass:
> > > +       debug("Copying bootstage from %p to %p\n", gd->bootstage, to);
> > > +       memcpy(to, gd->bootstage, sizeof(struct bootstage_data));
> > > +       data = gd->bootstage = to;
> >
> > should be a separate line (patman/checkpatch complains)
>
> I saw the suggestion of checkpatch.pl but ditched it as matter of taste.
> Do you want a v3?

It's OK I suppose. I used to hate that checkpatch.pl rule too, but
have come to get used to it...it avoids hiding the gd-> assignment
that my eye is looking for :-)

Regards,
Simon


>
> Thanks,
> //richard
>
> --
> sigma star gmbh | Eduard-Bodem-Gasse 6, 6020 Innsbruck, AUT
> UID/VAT Nr: ATU 66964118 | FN: 374287y
>
>


More information about the U-Boot mailing list