[PATCH 1/2] bootstage: Fix unstash of records from SPL

Simon Glass sjg at chromium.org
Tue Aug 6 23:50:48 CEST 2024


On Sat, 3 Aug 2024 at 08:16, Tom Rini <trini at konsulko.com> wrote:
>
> On Sat, Aug 03, 2024 at 12:41:44PM +0000, Jonas Karlman wrote:
>
> > The commit b81e31a1e6c5 ("bootstash: Do not provide a default address
> > for all") changed a bootstage unstash call to bootstage stash, this
> > has resulted in bootstage records stashed in SPL no longer get unstaged
> > in U-Boot proper. Fix this by changing back to a unstage call.
> >
> > Fixes: b81e31a1e6c5 ("bootstash: Do not provide a default address for all")
> > Signed-off-by: Jonas Karlman <jonas at kwiboo.se>
>
> Whoops, thanks!
>
> Reviewed-by: Tom Rini <trini at konsulko.com>

Reviewed-by: Simon Glass <sjg at chromium.org>

Thanks.

How about a test for sandbox_spl to check this? I see that
CONFIG_SPL_BOOTSTAGE is not enabled there.

There is a vaguely similar test in test/py/tests/test_handoff.py

Regards,
SImon


More information about the U-Boot mailing list