[PATCHv2 3/3] i2c: imx_lpi2c: Support read transfers longer than 256 bytes

Heiko Schocher hs at denx.de
Wed Aug 7 16:39:43 CEST 2024


Hello Fedor,

On 07.08.24 16:13, Fedor Ross wrote:
> On Wed, Aug 7, 2024 at 12:50 PM Heiko Schocher <hs at denx.de> wrote:
> 
> Hello Heiko,
> 
>> On 30.07.24 17:25, fedorross at gmail.com wrote:
>>> From: Fedor Ross <fedor.ross at ifm.com>
>>>
>>> The TXFIFO register of LPI2C only has one byte length, and if the length
>>> of the data that needs to be read exceeds 256 bytes, it needs to be
>>> written to TXFIFO multiple times.
>>>
>>> Signed-off-by: Fedor Ross <fedor.ross at ifm.com>
>>> ---
>>> Cc: Heiko Schocher <hs at denx.de>
>>> Cc: Tom Rini <trini at konsulko.com>
>>> Cc: Marek Vasut <marex at denx.de>
>>> ---
>>>
>>> Changes in v2:
>>> - Add additional '---' below SoB line to separate Cc list. This way it
>>>     does not get included in the commit message when the patch is applied.
>>> - Prefix 'CHUNK_DATA' macro with 'LPI2C_' to namespace it.
>>> - Do bit manipulation in writel() function directly and drop the
>>>     'val = assignment' .
>>>
>>>    drivers/i2c/imx_lpi2c.c | 71 ++++++++++++++++++++++++++---------------
>>>    1 file changed, 46 insertions(+), 25 deletions(-)
>>
>> Patch breaks world build, see for example
>>
>> https://dev.azure.com/hs0298/hs/_build/results?buildId=114&view=logs&j=9261107f-b16b-528d-034d-a5b366785bfc&t=aa057498-3634-5fad-2ef8-82ed58702aca&l=1197
>>
>> Find the whole pipeline (with other patches too...)
>>
>> https://dev.azure.com/hs0298/hs/_build/results?buildId=114&view=results
>>
>> Could you take a look please?
> 
> Done.

Thanks!

> Sorry for the inconvenience.

No problem.

bye,
Heiko
-- 
DENX Software Engineering GmbH,      Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52   Fax: +49-8142-66989-80   Email: hs at denx.de


More information about the U-Boot mailing list