[PATCH 1/1] board: rockchip: Add support for rk3588 GenBook
Andy Yan
andyshrk at 163.com
Mon Aug 12 12:00:55 CEST 2024
Hi Quetin,
在 2024-08-12 16:23:06,"Quentin Schulz" <quentin.schulz at cherry.de> 写道:
>Hi Andy,
>
>>> @@ -323,5 +329,6 @@ source "board/rockchip/evb_rk3588/Kconfig"
>>> source "board/rockchip/toybrick_rk3588/Kconfig"
>>> source "board/theobroma-systems/jaguar_rk3588/Kconfig"
>>> source "board/theobroma-systems/tiger_rk3588/Kconfig"
>>> +source "board/coolpi/genbook/Kconfig"
>>
>
>Order alphabetically here.
>
>>> diff --git a/board/coolpi/genbook/README b/board/coolpi/genbook/README
>>> new file mode 100644
>>> index 00000000000..ba165953154
>>> --- /dev/null
>>> +++ b/board/coolpi/genbook/README
>>
>
>We've moved the READMEs to doc/board/ so please do this as well.
>
>You may only want to add your board to doc/board/rockchip/rockchip.rst
>if the instructions in that file are good enough for you. Consider
>extending the content if it doesn't, and if it's too much work, then
>creating your own readme in doc/board/ similar to how Theobroma Systems
>boards are documented would do just fine.
>
>Note that those are in reStructuredText format (rST/Sphinx).
>
>>> diff --git
>>> a/dts/upstream/src/arm64/rockchip/rk3588-coolpi-cm5-genbook.dts
>>> b/dts/upstream/src/arm64/rockchip/rk3588-coolpi-cm5-genbook.dts
>>> new file mode 100644
>>> index 00000000000..6418286efe4
>>> --- /dev/null
>>> +++ b/dts/upstream/src/arm64/rockchip/rk3588-coolpi-cm5-genbook.dts
>>
>> I believe this should be turned into a separate commit, as a cherry-pick
>> of an upstream DT commit.
>>
>
>Yes, as a hint, you should be using tools/update-subtree.sh pick dts
><commit> as documented here:
>https://docs.u-boot.org/en/latest/develop/devicetree/control.html#resyncing-with-devicetree-rebasing
>
>You may need to pick more than one commit, that is fine.
>
>The commit id comes from
>https://git.kernel.org/pub/scm/linux/kernel/git/devicetree/devicetree-rebasing.git/.
The dts just landing linux-rockchip a few days agao,so it's not in the devicetree-rebasing repo,
Does that mean I should wait before it landing devicetree-rebasing repo ?
>
>
>Cheers,
>Quentin
More information about the U-Boot
mailing list