[PATCH v2 06/14] mmc: Use logging instead of pr_err()

[Simon Glass]

Hi Quentin,

On Mon, 12 Aug 2024 at 02:58, Quentin Schulz <quentin.schulz at cherry.de> wrote:
>
> Hi Simon,
>
> On 8/11/24 4:50 PM, Simon Glass wrote:
> > Hi Quentin,
> >
> > On Tue, 6 Aug 2024 at 08:10, Quentin Schulz <quentin.schulz at cherry.de> wrote:
> >>
> >> Hi Simon,
> >>
> >> On 7/21/24 5:25 PM, Simon Glass wrote:
> >>> Use the log subsystem instead of dev, to avoid including function names
> >>> in the code.
> >>>
> >>> The CONFIG_LOGF_FUNC option can be used to enable the function name.
> >>>
> >>> Signed-off-by: Simon Glass <sjg at chromium.org>
> >>> Reviewed-by: Sean Anderson <seanga2 at gmail.com>
> >>> ---
> >>>
> >>> (no changes since v1)
> >>>
> >>>    drivers/mmc/mmc.c | 49 ++++++++++++++++++++++++-----------------------
> >>>    1 file changed, 25 insertions(+), 24 deletions(-)
> >>>
> >>> diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c
> >>> index b18dc331f78..b0105afe5d6 100644
> >>> --- a/drivers/mmc/mmc.c
> >>> +++ b/drivers/mmc/mmc.c
> >>> @@ -294,7 +294,7 @@ int mmc_poll_for_busy(struct mmc *mmc, int timeout_ms)
> >>>
> >>>                if (status & MMC_STATUS_MASK) {
> >>>    #if !defined(CONFIG_SPL_BUILD) || defined(CONFIG_SPL_LIBCOMMON_SUPPORT)
> >>> -                     pr_err("Status Error: 0x%08x\n", status);
> >>> +                     log_err("Status Error: %08x\n", status);
> >>
> >> Please don't remove the 0x prefix (will not comment on other patches in
> >> this series if it happens again, please check :) ).
> >
> > OK...hex is the default though.
> >
>
> Can you please clarify what you meant by "it's the default though"?

U-Boot uses hex by default, so anything printed out or entered is
normally in hex. There are a few exceptions, not all of them correct.
I did send a series to allow decimal numbers but it has been deferred
for a while now[1].

Regards,
Simon

[1] https://patchwork.ozlabs.org/project/uboot/patch/20210724150341.243074-13-sjg@chromium.org/