[PATCH v3 31/40] efi: Show the vendor in helloworld

[Simon Glass]

Hi Heinrich,

On Mon, 12 Aug 2024 at 04:35, Heinrich Schuchardt <xypron.glpk at gmx.de> wrote:
>
> Am 12. August 2024 09:58:28 MESZ schrieb Ilias Apalodimas <ilias.apalodimas at linaro.org>:
> >On Sun, 11 Aug 2024 at 17:52, Simon Glass <sjg at chromium.org> wrote:
> >>
> >> Show the vendor name so it is clear which firmware is being used, e.g.
> >> whether U-Boot is providing the boot services.
>
> I never had any doubt about which firmware I am using.
>
> Originally you expected "U-Boot" to be printed on any device as indication of the copyright.
>
> Why is this patch needed? Are you checking the output anywhere?

Not at present. It is just nice to see U-Boot printed out when the test runs.

>
>
> >>
> >> Signed-off-by: Simon Glass <sjg at chromium.org>
> >> ---
> >>
> >> (no changes since v2)
> >>
> >> Changes in v2:
> >> - Reword commit message
> >> - Use 'Firmware vendor' instead of just 'Vendor'
> >>
> >>  lib/efi_loader/helloworld.c | 3 +++
> >>  1 file changed, 3 insertions(+)
> >>
> >> diff --git a/lib/efi_loader/helloworld.c b/lib/efi_loader/helloworld.c
> >> index 586177de0c8..c4d2afcb40a 100644
> >> --- a/lib/efi_loader/helloworld.c
> >> +++ b/lib/efi_loader/helloworld.c
> >> @@ -237,6 +237,9 @@ efi_status_t EFIAPI efi_main(efi_handle_t handle,
> >>                         (con_out, u"Missing device path for device handle\r\n");
> >>                 goto out;
> >>         }
> >> +       con_out->output_string(con_out, u"Firmware vendor: ");
> >> +       con_out->output_string(con_out, systab->fw_vendor);
> >> +       con_out->output_string(con_out, u"\n");
>
> How about FirmwareRevision"?

How about we start by getting this series in and then we can enhance it.

>
> Best regards
>
> Heinrich
>
> >>         con_out->output_string(con_out, u"Boot device: ");
> >>         ret = print_device_path(device_path, device_path_to_text);
> >>         if (ret != EFI_SUCCESS)
> >> --
> >> 2.34.1
> >>
> >Reviewed-by: Ilias Apalodimas <ilias.apalodimas at linaro.org>

Regards,
Simon