[PATCH] Kconfig: clean up the efi configuration status
Simon Glass
sjg at chromium.org
Fri Aug 16 03:34:30 CEST 2024
Hi Ilias,
On Thu, 15 Aug 2024 at 15:11, Ilias Apalodimas
<ilias.apalodimas at linaro.org> wrote:
>
>
>
> On Thu, Aug 15, 2024, 23:33 Simon Glass <sjg at chromium.org> wrote:
>>
>> Hi Ilias,
>>
>> On Wed, 14 Aug 2024 at 07:45, Ilias Apalodimas
>> <ilias.apalodimas at linaro.org> wrote:
>> >
>> > The EFI_LOADER and EFI config options are randomly scattered under lib/
>> > making it cumbersome to navigate and enable options, unless you really
>> > know what you are doing. On top of that the existing options are in
>> > random order instead of a logical one.
>> >
>> > So let's move things around a bit and present two enties for the
>>
>> entries
>>
>> > EFI_LOADER and EFI options in the main config screen.
>> > While at it add menus for Capsules, Protocols, and Services in the
>> > EFI_LOADER so people can find their way around easier
>> >
>> > Signed-off-by: Ilias Apalodimas <ilias.apalodimas at linaro.org>
>> > ---
>> > Kconfig | 4 +
>> > lib/Kconfig | 2 -
>> > lib/efi/Kconfig | 5 +
>> > lib/efi_loader/Kconfig | 202 +++++++++++++++++++++++------------------
>> > 4 files changed, 123 insertions(+), 90 deletions(-)
>> >
>> > diff --git a/Kconfig b/Kconfig
>> > index 82df59f176ec..62c5441e3576 100644
>> > --- a/Kconfig
>> > +++ b/Kconfig
>> > @@ -756,3 +756,7 @@ source "lib/Kconfig"
>> > source "test/Kconfig"
>> >
>> > source "tools/Kconfig"
>> > +
>> > +source "lib/efi_loader/Kconfig"
>> > +
>>
>> This should be included from boot/Kconfig as it relates to booting.
>
>
> Hmm why? Booting is one of the things efi does. I prefer having it on the main menu since it's a pointer to the entire spec, protocols, services etc
True. From a functionality point of view, there is booting and
firmware update. Is there anything else? I have thought for a while
that we should perhaps have an 'update' menu. Where, for example,
would VBE fit in the menus?
>
>
>>
>> The EFI app thing should perhaps be under there too...I'm not sure.
>
>
> I was toying around with the idea as well. But eventually I decided this needs it's own entry since it's about building U-Boot as a pe/coff. I don't mind changing this though.
Yes, building as an app isn't really about booting. It looks very
lonely at the end of the menu, though.
Regards,
Simon
>
> Thanks
> Ilias
>>
>>
>> Regards,
>> Simon
More information about the U-Boot
mailing list