[RESEND PATCH v3 3/9] net/tcp: put connection specific data into a tcp_stream structure

Simon Glass sjg at chromium.org
Sat Aug 17 17:58:19 CEST 2024


Hi Mikhail,

On Wed, 14 Aug 2024 at 04:32, Mikhail Kshevetskiy
<mikhail.kshevetskiy at iopsys.eu> wrote:
>
> no functional changes
>
> Signed-off-by: Mikhail Kshevetskiy <mikhail.kshevetskiy at iopsys.eu>
> ---
>  include/net/tcp.h |  37 +++++++-
>  net/net.c         |  11 ++-
>  net/tcp.c         | 231 +++++++++++++++++++++++-----------------------
>  net/wget.c        |   3 +-
>  4 files changed, 163 insertions(+), 119 deletions(-)

Reviewed-by: Simon Glass <sjg at chromium.org>

BTW it doesn't make a lot of sense to have a 'u8' function argument,
since it is passed in a register. It may force the compiler to mask
the value, adding to code size.

Regards,
Simon


More information about the U-Boot mailing list