[PATCH v2 2/7] dts: qcs6490-rb3gen2-u-boot: add override dtsi

[Simon Glass]

Hi Caleb,

On Wed, 21 Aug 2024 at 07:42, Caleb Connolly <caleb.connolly at linaro.org> wrote:
>
> For running U-Boot as primary bootloader we must define the memory
> layout statically.
>
> Signed-off-by: Caleb Connolly <caleb.connolly at linaro.org>
> ---
>  arch/arm/dts/qcs6490-rb3gen2-u-boot.dtsi | 23 +++++++++++++++++++++++
>  1 file changed, 23 insertions(+)
>
> diff --git a/arch/arm/dts/qcs6490-rb3gen2-u-boot.dtsi b/arch/arm/dts/qcs6490-rb3gen2-u-boot.dtsi
> new file mode 100644
> index 000000000000..c3ec4a317f7c
> --- /dev/null
> +++ b/arch/arm/dts/qcs6490-rb3gen2-u-boot.dtsi
> @@ -0,0 +1,23 @@
> +// SPDX-License-Identifier: BSD-3-Clause
> +/*
> + * Copyright (c) 2024 Linaro Ltd.
> + */
> +/ {
> +       /* When running as the primary bootloader there is no prior

We normally have an empty /* on the first line

> +        * stage to populate the memory layout for us. We *should*
> +        * have two nodes here, but ABL does NOT like that.
> +        * sooo we're stuck with this.
> +        */
> +       memory at 80000000 {
> +               device_type = "memory";
> +               reg = <0 0x80000000 0 0x3A800000>,
> +                     <0 0xC0000000 0 0x01800000>,
> +                     <0 0xC3400000 0 0x3CC00000>,
> +                     <1 0x00000000 1 0x00000000>;
> +       };
> +};
> +
> +// RAM Entry 0 : Base 0x0080000000  Size 0x003A800000
> +// RAM Entry 1 : Base 0x00C0000000  Size 0x0001800000
> +// RAM Entry 2 : Base 0x00C3400000  Size 0x003CC00000
> +// RAM Entry 3 : Base 0x0100000000  Size 0x0100000000
>
> --
> 2.46.0
>

Can you please use lower-case hex?

Regards,
Simon