[PATCH v2 1/7] clk/qcom: add initial clock driver for sc7280

Simon Glass sjg at chromium.org
Wed Aug 21 16:37:12 CEST 2024


Hi Caleb,

On Wed, 21 Aug 2024 at 08:11, Caleb Connolly <caleb.connolly at linaro.org> wrote:
>
> Hi Simon,
> >> +U_BOOT_DRIVER(gcc_sc7280) = {
> >> +       .name           = "gcc_sc7280",
> >> +       .id             = UCLASS_NOP,
> >> +       .of_match       = gcc_sc7280_of_match,
> >> +       .bind           = qcom_cc_bind,
> >> +       .flags          = DM_FLAG_PRE_RELOC | DM_FLAG_DEFAULT_PD_CTRL_OFF,
> >> +};
> >
> > This should use driver model, with a UCLASS_CLK and UCLASS_RESET
>
> Please refer to qcom_cc_bind() which binds the clock, reset, and power
> domain drivers.

Gosh, why? Are these devices not in the devicetree?

Regards,
Simon


More information about the U-Boot mailing list