[PATCH v3 07/15] mmc: Use logging instead of pr_err()

Simon Glass sjg at chromium.org
Thu Aug 22 15:55:18 CEST 2024


Hi Quentin,

On Mon, 12 Aug 2024 at 03:40, Quentin Schulz <quentin.schulz at cherry.de> wrote:
>
> Hi Simon,
>
> On 8/11/24 2:29 PM, Simon Glass wrote:
> > Use the log subsystem instead of dev, to avoid including function names
> > in the code.
> >
> > The CONFIG_LOGF_FUNC option can be used to enable the function name.
> >
> > Signed-off-by: Simon Glass <sjg at chromium.org>
> > Reviewed-by: Sean Anderson <seanga2 at gmail.com>
> > ---
> >
> > Changes in v3:
> > - Fix 'enver' typo while we are here
> > - Put enhanced size back to decimal
>
> Did you? Isn't it still using hex base via %#x printf format?
>
> Since the base is explicit and is what I requested in case we changed
> the printf format from decimal to hex base:
>
> Reviewed-by: Quentin Schulz <quentin.schulz at cherry.de>

Ooops yes I didn't to that. But if you are OK with hex I think that is
better, given the large numbers involved.

Regards,
Simon


More information about the U-Boot mailing list