[PATCH v2 26/35] global_data: Reduce size of early-malloc vars

Simon Glass sjg at chromium.org
Fri Aug 23 22:30:04 CEST 2024


Hi Tom,

On Fri, 23 Aug 2024 at 07:34, Tom Rini <trini at konsulko.com> wrote:
>
> On Wed, Aug 21, 2024 at 10:19:18AM -0600, Simon Glass wrote:
>
> > The early malloc region is normally quite small and is certainly less
> > than 4GB, so use a 32-bit value for the limit and pointer. Update the
> > comment for clarity while we are here.
> >
> > Signed-off-by: Simon Glass <sjg at chromium.org>
> > ---
> >
> > (no changes since v1)
> >
> >  arch/arm/lib/bdinfo.c             | 2 +-
> >  common/board_r.c                  | 2 +-
> >  common/malloc_simple.c            | 7 ++++---
> >  common/spl/spl.c                  | 4 ++--
> >  include/asm-generic/global_data.h | 6 +++---
> >  5 files changed, 11 insertions(+), 10 deletions(-)
>
> This breaks booting on am64x_evm_a53 which is an odd platform that does
> SPL->SPL->U-Boot.

OK, I can repeat that on the Beagleplay in my lab. I sent a v3 patch.
Thanks for bisecting.

I'd love to be able to push trees to gitlab and have them run on my
lab. I think you said that the patches[1] break your lab, so let me
know if there is anything I can fix.

Regards,
Simon

[1] https://patchwork.ozlabs.org/project/uboot/list/?series=420392


More information about the U-Boot mailing list