[PATCH 1/1] usb: gadget: ether: Disable USB pullup in eth probe

Marek Vasut marex at denx.de
Mon Aug 26 16:40:09 CEST 2024


On 8/26/24 11:12 AM, Zixun LI wrote:
> On Sun, Aug 25, 2024 at 2:13 AM Marek Vasut <marex at denx.de> wrote:
>>
>>>
>>> I am looking at the usb_add_gadget_udc_release() and
>>> usb_gadget_probe_driver() and I am thinking, sigh, all that code is
>>> ready to be replaced by something cleaner which does not use this
>>> special struct usb_udc and udc_list, but instead only uses U-Boot DM
>>> udevices . But I am reluctant to ask you to do all that rework, because
>>> that is WAY out of scope of the problem you are trying to fix.
>>
> 
> Thank you for looking into this, refactor udc core could make things clear.

Sigh, yeah, I think you ran into part of the UDC code which is just ... 
not great ... sorry about that.

>> Maybe this could be a start (compile tested only):
>>
>> https://source.denx.de/u-boot/custodians/u-boot-sh/-/commits/usb-udc-udevice
> 
> Tested no regression with usba_udc.

Thanks for testing, patches posted.


More information about the U-Boot mailing list