[PATCH] mkimage: ecdsa: add signature/key nodes to dtb if missing

Matthias Pritschet matthias at pritschet.eu
Tue Aug 27 21:47:42 CEST 2024


Am 27.08.24 um 20:40 schrieb Peter Robinson:
> On Tue, 27 Aug 2024 at 18:52, Matthias Pritschet <matthias at pritschet.eu> wrote:
>>
>> From: Matthias Pritschet <matthias.pritschet at itk-engineering.de>
>>
>> If the signature/key node(s) are not yet present in the U-Boot device
>> tree, ecdsa_add_verify_data simply fails if it can't find the nodes.
>> This behaviour differs from rsa_add_verify_data, wich does add the missing
>> nodes and proceeds in that case.
>>
>> This change is mainly copy&paste from rsa_add_verify_data to add the
>> same behaviour to ecdsa_add_verify_data.
> 
> Could the duplicated code be moved out into a function shared between
> the two *_add_verify_data bits of code?
> 

I don't see a reason why not.
However, I'm not too familiar with the codebase and not sure where to put it.

If you think it's worth it and give me a few pointers regarding where and how to implement it, I'll happily draft a v2.

-- 
Matthias



More information about the U-Boot mailing list