[EXTERNAL] Re: [PATCH 1/6] arm: dts: k3-j7200-r5: Add the pmic node in R5 dt

Limaye, Aniket a-limaye at ti.com
Thu Aug 29 10:32:43 CEST 2024



On 6/14/2024 8:25 PM, Tom Rini wrote:
> On Fri, May 31, 2024 at 10:24:30PM +0530, Limaye, Aniket wrote:
>>
>>
>> On 5/31/2024 7:25 PM, Kumar, Udit wrote:
>>>
>>> On 5/31/2024 6:38 PM, Aniket Limaye wrote:
>>>> Add bootph-pre-ram property to the buck node in the pmic needed for
>>>> ESM error event handling.
>>>>
>>>> Signed-off-by: Aniket Limaye <a-limaye at ti.com>
>>>> ---
>>>>    arch/arm/dts/k3-j7200-r5-common-proc-board.dts | 9 +++++++++
>>>>    1 file changed, 9 insertions(+)
>>>>
>>>> diff --git a/arch/arm/dts/k3-j7200-r5-common-proc-board.dts
>>>> b/arch/arm/dts/k3-j7200-r5-common-proc-board.dts
>>>> index fb7e2e50239..78d07ff4e70 100644
>>>> --- a/arch/arm/dts/k3-j7200-r5-common-proc-board.dts
>>>> +++ b/arch/arm/dts/k3-j7200-r5-common-proc-board.dts
>>>> @@ -96,3 +96,12 @@
>>>>    &mcu_udmap {
>>>>        ti,sci = <&dm_tifs>;
>>>>    };
>>>> +
>>>> +&tps659414 {
>>>> +    regulators {
>>>> +        bucka1: buck1 {
>>>> +            bootph-pre-ram;
>>>> +        };
>>>
>>>
>>> why not to add this in kernel DT
>>
>> Manorit has already posted a series to kernel to add bootph- properties
>> across platforms... Specifically the patch here [0] addresses this.
>>
>> Once that is merged, and goes through the rebasing tree in u-boot we will
>> need to send patches to remove the bootph properties from the -u-boot and
>> -r5 files. Until then we need this patch for the ESM to work. Else we can
>> wait till the kernel dt patches make it through to u-boot for me to roll out
>> a v2.
> 
> Yes, we'll wait until we can get this all in via OF_UPSTREAM.
> 

Tom, Udit,

The patch in Kernel DT here [0] seems to be taking longer to go through.
In the meantime, does it make sense for me to send this current series 
in u-boot with the bootph patch above, to unblock ESM support for j7200-evm?

When the Kernel DT patch is merged and taken through OF_UPSTREAM, I will 
anyway send a patch to remove all of the bootph from the u-boot DT 
files. With that, I can take care of removing the above bootph property too.

Let me know what you think, and I'll rebase this series and resend it then.

[0]: 
https://lore.kernel.org/all/20240814-b4-upstream-bootph-all-v4-0-f2b462000f25@ti.com/

Thanks,
Aniket


More information about the U-Boot mailing list