[PATCH] mach-imx: do not use if_changed more than once per target

Fabio Estevam festevam at gmail.com
Thu Aug 29 14:52:44 CEST 2024


Hi Jerome,

On Wed, Aug 28, 2024 at 12:37 PM Jerome Forissier
<jerome.forissier at linaro.org> wrote:
>
> doc/develop/makefiles.rst has the following note:
>
>   if_changed should not be used more than once per target.
>   It stores the executed command in a corresponding .cmd
>   file and multiple calls would result in overwrites and
>   unwanted results when the target is up to date and only the
>   tests on changed commands trigger execution of commands.
>
> The mach-imx Makefile does not follow this recommandation, so fix it
> by implementing a single command that performs both the cpp_cfg
> and imx9_check actions.
>
> This change fixes an issue with "tools/buildman/buildman imx8ulp_evk"
> failing every other time [1].
>
> [1] https://lists.denx.de/pipermail/u-boot/2024-August/563192.html
>
> Fixes: f637dfe8c468 ("mach-imx: Add i.MX93 binman support.")
> Signed-off-by: Jerome Forissier <jerome.forissier at linaro.org>

Thanks for the fix.

Applied to u-boot-imx/master, thanks.


More information about the U-Boot mailing list