[PATCH v4 4/9] usb: cdns: starfive: Add cdns USB driver

[Marek Vasut]

On 8/29/24 3:30 AM, Minda Chen wrote:
> Add cdns USB3 wrapper driver.
> 
> Signed-off-by: Minda Chen <minda.chen at starfivetech.com>
> ---
>   drivers/usb/cdns3/Kconfig          |   7 ++
>   drivers/usb/cdns3/Makefile         |   2 +
>   drivers/usb/cdns3/cdns3-starfive.c | 191 +++++++++++++++++++++++++++++
>   3 files changed, 200 insertions(+)
>   create mode 100644 drivers/usb/cdns3/cdns3-starfive.c
> 
> diff --git a/drivers/usb/cdns3/Kconfig b/drivers/usb/cdns3/Kconfig
> index 35b61497d9..f8f363982b 100644
> --- a/drivers/usb/cdns3/Kconfig
> +++ b/drivers/usb/cdns3/Kconfig
> @@ -55,4 +55,11 @@ config USB_CDNS3_TI
>   	help
>   	  Say 'Y' here if you are building for Texas Instruments
>   	  platforms that contain Cadence USB3 controller core. E.g.: J721e.
> +
> +config USB_CDNS3_STARFIVE
> +	tristate "Cadence USB3 support on Starfive platforms"
> +	default USB_CDNS3

Should this be 'default y if SOMEPLATFORM' ?

[...]

> +static void cdns_mode_init(struct cdns_starfive *data, enum usb_dr_mode mode)
> +{
> +	unsigned int strap, suspendm;
> +
> +	regmap_update_bits(data->stg_syscon, data->stg_usb_mode,
> +			   USB_MISC_CFG_MASK,
> +			   USB_SUSPENDM_BYPS | USB_PLL_EN | USB_REFCLK_MODE);
> +
> +	switch (mode) {
> +	case USB_DR_MODE_HOST:
> +		strap = USB_STRAP_HOST;
> +		suspendm = USB_SUSPENDM_HOST;
> +		break;
> +
> +	case USB_DR_MODE_PERIPHERAL:
> +		strap = USB_STRAP_DEVICE;
> +		suspendm = 0;
> +		break;
> +	default:
> +		return;
> +	}
> +
> +	regmap_update_bits(data->stg_syscon, data->stg_usb_mode,
> +			   USB_STRAP_MASK, strap);
> +	regmap_update_bits(data->stg_syscon, data->stg_usb_mode,
> +			   USB_SUSPENDM_MASK, suspendm);

Are two consecutive writes to the same register mandatory here ?

> +}

[...]

> +static int cdns_starfive_probe(struct udevice *dev)
> +{
> +	struct cdns_starfive *data = dev_get_plat(dev);
> +	enum usb_dr_mode dr_mode;
> +	ofnode node;
> +	int ret;
> +
> +	data->dev = dev;
> +
> +	ret = cdns_starfive_get_syscon(data);
> +	if (ret)
> +		return ret;
> +
> +	node = ofnode_by_compatible(dev_ofnode(dev), "cdns,usb3");
> +	if (!ofnode_valid(node)) {
> +		dev_err(dev, "failed to get usb node\n");

USB in capitals.

> +		return -ENODEV;
> +	}
> +
> +	dr_mode = usb_get_dr_mode(node);
> +
> +	data->mode = dr_mode;
> +	ret = cdns_clk_rst_init(data);
> +	if (ret) {
> +		dev_err(data->dev, "clk reset failed: %d\n", ret);
> +		return ret;
> +	}
> +	cdns_mode_init(data, dr_mode);
> +
> +	return 0;
> +}

Looks pretty good, thanks .