[PATCH 2/3] smbios: do not determine maximum structure size

Heinrich Schuchardt heinrich.schuchardt at canonical.com
Thu Feb 1 01:20:21 CET 2024


Only the SMBIOS 2.1 entry point has a field for the maximum structure size.
As we have switched to an SMBIOS 3 entry point remove the superfluous
calculation.

Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt at canonical.com>
---
 lib/smbios.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/lib/smbios.c b/lib/smbios.c
index cd750cc218..327f78c8b0 100644
--- a/lib/smbios.c
+++ b/lib/smbios.c
@@ -566,7 +566,6 @@ ulong write_smbios_table(ulong addr)
 	struct smbios_ctx ctx;
 	ulong tables;
 	int len = 0;
-	int max_struct_size = 0;
 	int handle = 0;
 	int i;
 
@@ -588,7 +587,6 @@ ulong write_smbios_table(ulong addr)
 	/* populate minimum required tables */
 	for (i = 0; i < ARRAY_SIZE(smbios_write_funcs); i++) {
 		const struct smbios_write_method *method;
-		int tmp;
 
 		method = &smbios_write_funcs[i];
 		ctx.subnode_name = NULL;
@@ -598,10 +596,7 @@ ulong write_smbios_table(ulong addr)
 				ctx.node = ofnode_find_subnode(parent_node,
 							       method->subnode_name);
 		}
-		tmp = method->write((ulong *)&addr, handle++, &ctx);
-
-		max_struct_size = max(max_struct_size, tmp);
-		len += tmp;
+		len += method->write((ulong *)&addr, handle++, &ctx);
 	}
 
 	/*
-- 
2.43.0



More information about the U-Boot mailing list