[PATCH v3 1/3] firmware: psci: Fix bind_smccc_features psci check
Abdellatif El Khlifi
abdellatif.elkhlifi at arm.com
Thu Feb 1 12:40:30 CET 2024
Hi Weizhao,
> - if (request_psci_features(ARM_SMCCC_ARCH_FEATURES) ==
> + if (request_psci_features(ARM_SMCCC_VERSION) ==
> PSCI_RET_NOT_SUPPORTED)
> return 0;
>
> + if (invoke_psci_fn(ARM_SMCCC_VERSION, 0, 0, 0) < ARM_SMCCC_VERSION_1_1)
> + return 0;
It makes sense to me, thanks.
> diff --git a/include/linux/arm-smccc.h b/include/linux/arm-smccc.h
> index f44e9e8f93..da3d29aabe 100644
> --- a/include/linux/arm-smccc.h
> +++ b/include/linux/arm-smccc.h
> @@ -55,8 +55,14 @@
> #define ARM_SMCCC_QUIRK_NONE 0
> #define ARM_SMCCC_QUIRK_QCOM_A6 1 /* Save/restore register a6 */
>
> +#define ARM_SMCCC_VERSION 0x80000000
> #define ARM_SMCCC_ARCH_FEATURES 0x80000001
>
> +#define ARM_SMCCC_VERSION_1_0 0x10000
> +#define ARM_SMCCC_VERSION_1_1 0x10001
> +#define ARM_SMCCC_VERSION_1_2 0x10002
> +#define ARM_SMCCC_VERSION_1_3 0x10003
Apart from ARM_SMCCC_VERSION_1_1, are the other ARM_SMCCC_VERSION_1_x defines needed ?
Cheers,
Abdellatif
More information about the U-Boot
mailing list