[PATCH v3 17/36] mach-snapdragon: generalise board support

[Caleb Connolly]

[snip]

>> diff --git a/configs/dragonboard845c_defconfig b/configs/dragonboard845c_defconfig
>> deleted file mode 100644
>> index f29f11e342e7..000000000000
>> --- a/configs/dragonboard845c_defconfig
>> +++ /dev/null
>> @@ -1,29 +0,0 @@
>> -CONFIG_ARM=y
>> -CONFIG_SKIP_LOWLEVEL_INIT=y
>> -CONFIG_COUNTER_FREQUENCY=19000000
>> -CONFIG_POSITION_INDEPENDENT=y
>> -CONFIG_ARCH_SNAPDRAGON=y
>> -CONFIG_DEFAULT_DEVICE_TREE="dragonboard845c"
>> -CONFIG_TARGET_DRAGONBOARD845C=y
>> -CONFIG_IDENT_STRING="\nQualcomm-DragonBoard 845C"
>> -CONFIG_SYS_LOAD_ADDR=0x80000000
>> -CONFIG_FIT=y
>> -CONFIG_FIT_VERBOSE=y
>> -CONFIG_BOOTDELAY=5
>> -CONFIG_SAVE_PREV_BL_FDT_ADDR=y
>> -CONFIG_SAVE_PREV_BL_INITRAMFS_START_ADDR=y
> 
> I would suggest keeping this config option in new qcom_defconfig since
> it allows to package FIT image as intramfs within boot.img...

Ah for sure, nice catch.

I know this is a pretty huge patch, but for future reference please
could you trim down irrelevant stuff when replying? Otherwise it's easy
to miss your comments...

[snip]

>> diff --git a/include/configs/qcom.h b/include/configs/qcom.h
>> new file mode 100644
>> index 000000000000..e50b3bce5cdd
>> --- /dev/null
>> +++ b/include/configs/qcom.h
>> @@ -0,0 +1,21 @@
>> +/* SPDX-License-Identifier: GPL-2.0+ */
>> +/*
>> + * Configuration file for Qualcomm Snapdragon boards
>> + *
>> + * (C) Copyright 2021 Dzmitry Sankouski <dsankouski at gmail.com>
>> + * (C) Copyright 2023 Linaro Ltd.
>> + */
>> +
>> +#ifndef __CONFIGS_SNAPDRAGON_H
>> +#define __CONFIGS_SNAPDRAGON_H
>> +
>> +#define CFG_SYS_BAUDRATE_TABLE { 115200, 230400, 460800, 921600 }
>> +
>> +/* Load addressed are calculated during board_late_init(). See arm/mach-snapdragon/board.c */
>> +#define CFG_EXTRA_ENV_SETTINGS \
>> +       "stdin=serial,button-kbd\0"     \
>> +       "stdout=serial,vidconsole\0"    \
>> +       "stderr=serial,vidconsole\0" \
>> +       "bootcmd=bootm $prevbl_initrd_start_addr\0"
> 
> ...as otherwise this bootcmd won't work.
> 
> -Sumit
> 
>> +

-- 
// Caleb (they/them)