[PATCH v2 2/2] smbios: fill wake-up type

Heinrich Schuchardt heinrich.schuchardt at canonical.com
Fri Feb 9 16:51:15 CET 2024


We should not use the reserved value 0x00 for the wake up type but
use 0x02 (Unknown).

Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt at canonical.com>
---
v2:
	use wake-up type 'Unknown' as our default
	add more SMBIOS wake-up type constants
---
 include/smbios.h | 10 ++++++++++
 lib/smbios.c     |  1 +
 2 files changed, 11 insertions(+)

diff --git a/include/smbios.h b/include/smbios.h
index 3df8827b60d..990e37b4d2b 100644
--- a/include/smbios.h
+++ b/include/smbios.h
@@ -108,6 +108,16 @@ struct __packed smbios_type0 {
 	char eos[SMBIOS_STRUCT_EOS_BYTES];
 };
 
+#define SMBIOS_WAKEUP_TYPE_RESERVED		0x00
+#define SMBIOS_WAKEUP_TYPE_OTHER		0x01
+#define SMBIOS_WAKEUP_TYPE_UNKNOWN		0x02
+#define SMBIOS_WAKEUP_TYPE_APM_TIME		0x03
+#define SMBIOS_WAKEUP_TYPE_MODEM_RING		0x04
+#define SMBIOS_WAKEUP_TYPE_LAN_REMOTE		0x05
+#define SMBIOS_WAKEUP_TYPE_POWER_SWITCH		0x06
+#define SMBIOS_WAKEUP_TYPE_PCI_PME		0x07
+#define SMBIOS_WAKEUP_TYPE_AC_POWER_RESTORED	0x08
+
 struct __packed smbios_type1 {
 	u8 type;
 	u8 length;
diff --git a/lib/smbios.c b/lib/smbios.c
index c83af730a91..b190b010f30 100644
--- a/lib/smbios.c
+++ b/lib/smbios.c
@@ -394,6 +394,7 @@ static int smbios_write_type1(ulong *current, int handle,
 	} else {
 		t->serial_number = smbios_add_prop(ctx, "serial", NULL);
 	}
+	t->wakeup_type = SMBIOS_WAKEUP_TYPE_UNKNOWN;
 	t->sku_number = smbios_add_prop(ctx, "sku", NULL);
 	t->family = smbios_add_prop(ctx, "family", NULL);
 
-- 
2.43.0



More information about the U-Boot mailing list