[PATCH] button: qcom-pmic: demote "unknown button" message to debug

Neil Armstrong neil.armstrong at linaro.org
Mon Feb 12 10:55:30 CET 2024


On 09/02/2024 16:11, Caleb Connolly wrote:
> This message isn't an error (there can be a watchdog subnode for example)
> but it shouldn't be printed unless this driver is being debugged. Demote
> it to a debug print.
> 
> Signed-off-by: Caleb Connolly <caleb.connolly at linaro.org>
> ---
>   drivers/button/button-qcom-pmic.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/button/button-qcom-pmic.c b/drivers/button/button-qcom-pmic.c
> index 34a976d1e6c6..e6702139ca2d 100644
> --- a/drivers/button/button-qcom-pmic.c
> +++ b/drivers/button/button-qcom-pmic.c
> @@ -133,7 +133,7 @@ static int button_qcom_pmic_bind(struct udevice *parent)
>   		} else if (NODE_IS_RESIN(node)) {
>   			uc_plat->label = "vol_down";
>   		} else {
> -			printf("Unknown button node '%s' should be 'pwrkey' or 'resin'\n",
> +			debug("Unknown button node '%s' should be 'pwrkey' or 'resin'\n",
>   			       ofnode_get_name(node));
>   			device_unbind(dev);
>   		}

Reviewed-by: Neil Armstrong <neil.armstrong at linaro.org>


More information about the U-Boot mailing list