[PATCH v2 5/6] efi_selftest: Add box drawing character selftest

[Heinrich Schuchardt]

On 10.02.24 13:46, Janne Grunau via B4 Relay wrote:
> From: Andre Przywara <andre.przywara at arm.com>
>
> UEFI applications rely on Unicode output capability, and might use that
> for drawing pseudo-graphical interfaces using Unicode defined box
> drawing characters.
>
> Add a simple test to display the most basic box characters, which would
> need to be checked manually on the screen for correctness.
> To facilitate this, add a three second delay after the output at this
> point.
>
> Signed-off-by: Andre Przywara <andre.przywara at arm.com>
> Suggested-by: Heinrich Schuchardt <xypron.glpk at gmx.de>
> Signed-off-by: Janne Grunau <j at jannau.net>
> ---
>   lib/efi_selftest/efi_selftest_textoutput.c | 20 ++++++++++++++++++++
>   1 file changed, 20 insertions(+)
>
> diff --git a/lib/efi_selftest/efi_selftest_textoutput.c b/lib/efi_selftest/efi_selftest_textoutput.c
> index 2aa81b0a80..cc11a22eee 100644
> --- a/lib/efi_selftest/efi_selftest_textoutput.c
> +++ b/lib/efi_selftest/efi_selftest_textoutput.c
> @@ -33,6 +33,19 @@ static int execute(void)
>   	const u16 text[] =
>   u"\u00d6sterreich Edelwei\u00df Sm\u00f8rrebr\u00f8d Sm\u00f6rg"
>   u"\u00e5s Ni\u00f1o Ren\u00e9 >\u1f19\u03bb\u03bb\u03ac\u03c2<\n";
> +	const u16 boxes[] =
> +u"This should render as four boxes with text\n"
> +u"\u250c\u2500\u2500\u2500\u2500\u2500\u2500\u2500\u2500\u2500\u2500"
> +u"\u2500\u2500\u2500\u252c\u2500\u2500\u2500\u2500\u2500\u2500\u2500"
> +u"\u2500\u2500\u2500\u2500\u2500\u2500\u2500\u2500\u2510\n\u2502"
> +u" left top    \u2502 right top     \u2502\n\u251c\u2500"
> +u"\u2500\u2500\u2500\u2500\u2500\u2500\u2500\u2500\u2500\u2500\u2500"
> +u"\u2500\u253c\u2500\u2500\u2500\u2500\u2500\u2500\u2500\u2500\u2500"
> +u"\u2500\u2500\u2500\u2500\u2500\u2500\u2524\n\u2502 "
> +u"left bottom \u2502 right bottom  \u2502\n\u2514\u2500\u2500\u2500"
> +u"\u2500\u2500\u2500\u2500\u2500\u2500\u2500\u2500\u2500\u2500\u2534"
> +u"\u2500\u2500\u2500\u2500\u2500\u2500\u2500\u2500\u2500\u2500\u2500"
> +u"\u2500\u2500\u2500\u2500\u2518\n";
>
>   	/* SetAttribute */
>   	efi_st_printf("\nColor palette\n");
> @@ -126,6 +139,13 @@ u"\u00e5s Ni\u00f1o Ren\u00e9 >\u1f19\u03bb\u03bb\u03ac\u03c2<\n";
>   		efi_st_error("OutputString failed for international chars\n");
>   		return EFI_ST_FAILURE;
>   	}
> +	ret = con_out->output_string(con_out, boxes);
> +	if (ret != EFI_ST_SUCCESS) {
> +		efi_st_error("OutputString failed for box drawing chars\n");
> +		return EFI_ST_FAILURE;
> +	}
> +	con_out->output_string(con_out, u"waiting for admiration...\n");
> +	EFI_CALL(systab.boottime->stall(3000000));

We don't want to add any unnecessary waiting times in the unit tests. If
somebody wants to see the output, he can scroll up.

Best regards

Heinrich

>   	efi_st_printf("\n");
>
>   	return EFI_ST_SUCCESS;
>