[PATCH v3 2/3] board: Add support for Sielaff i.MX6 Solo board
Dan Carpenter
dan.carpenter at linaro.org
Tue Feb 20 09:49:22 CET 2024
On Tue, Feb 20, 2024 at 09:38:01AM +0100, Frieder Schrempf wrote:
> Hi Dan,
>
> On 20.02.24 06:56, Dan Carpenter wrote:
> > On Thu, Feb 15, 2024 at 02:35:20PM +0100, Frieder Schrempf wrote:
> >> +int board_mmc_getcd(struct mmc *mmc)
> >
> > This function is never called. Also for bool functions make them type
> > bool and name them so that it's clear they return true/false such as
> > board_mmc_getcd_was_successful() but less wordy.
>
> What makes you think so? This is an implementation for the existing
> prototype from mmc.h. As far as I can see this is called by the mmc
> driver and I can't change it in any way.
>
Ah, yes. You're right. My bad.
regards,
dan carpenter
More information about the U-Boot
mailing list