[PATCH v2 2/8] reset: imx: Add support for i.MX8MP reset controller

Marek Vasut marex at denx.de
Mon Feb 26 14:08:10 CET 2024


On 2/26/24 1:59 PM, Sumit Garg wrote:
> On Mon, 26 Feb 2024 at 16:11, Marek Vasut <marex at denx.de> wrote:
>>
>> On 2/26/24 11:33 AM, Sumit Garg wrote:
>>> On Mon, 26 Feb 2024 at 14:24, Marek Vasut <marex at denx.de> wrote:
>>>>
>>>> On 2/26/24 9:04 AM, Sumit Garg wrote:
>>>>> Add support for i.MX8MP reset controller, it has same reset IP
>>>>
>>>> Same as what ?
>>>
>>> I can expand it.
>>
>> This does not answer the question .
>>
> 
> The other iMX7 and iMX8 variants.

Please add that to the commit message.

>>>>> inside
>>>>> but with different module layout.
>>>>>
>>>>> Inspired from counterpart Linux kernel v6.8-rc3 driver:
>>>>> drivers/reset/reset-imx7.c.
>>>>
>>>> Use commit ID of the last change in that driver:
>>>>
>>>> bad8a8afe19f ("reset: Explicitly include correct DT includes")
>>>>
>>>> I guess
>>>
>>> Why isn't the Linux kernel tag sufficient here? I don't see the value
>>> of cross referencing commits across different git projects.
>>
>> The commit ID is a unique identifier, tag can be rewritten .
> 
> Similar arguments can be made for git commit history.

If you do rewrite history, then the commit IDs would have changed, right ?

The original commit ID would still describe the exact (old) state, the 
new rewritten history would have new commit IDs which describe the exact 
(new) state.


More information about the U-Boot mailing list