[PATCH v2 5/8] phy: phy-imx8m-pcie: Add support for i.MX8M{M/P} PCIe PHY

[Sumit Garg]

On Mon, 26 Feb 2024 at 18:34, Marek Vasut <marex at denx.de> wrote:
>
> On 2/26/24 1:50 PM, Sumit Garg wrote:
>
> [...]
>
> >>> +     ret = reset_get_by_name(dev, "pciephy", &imx8_phy->reset);
> >>> +     if (ret) {
> >>> +             dev_err(dev, "Failed to get PCIEPHY reset control\n");
> >>> +             return ret;
> >>> +     }
> >>
> >> Some clk_put() and co. fail path is missing here.
> >
> > Ditto for clk_put() not being available. However, I can add the fail
> > path for the other reset.
>
> Oh, maybe reset_free() and clk_release*() then ?

AFAICS, clk_release*() APIs are internally only a wrapper around
clk_disable(). So actually those APIs don't seem to do anything useful
in the fail path here.

However, I will let clock tree maintainers chime in here if they plan
to remove clk_release*() APIs on similar lines as with clk_free().

-Sumit