[PATCH 05/10] mach-snapdragon: Update gd->ram_size in msm_fixup_memory

Dan Carpenter dan.carpenter at linaro.org
Mon Feb 26 16:41:01 CET 2024


On Mon, Feb 26, 2024 at 03:38:02PM +0530, Varadarajan Narayanan wrote:
> 
> * Update FDT only if 'blob' is not null

It seems that this is patching up a bug that was introduced in patch
1/10.  Please fold it into patch 1.

> @@ -91,9 +93,9 @@ int msm_fixup_memory(void *blob)
>  		return -ENODEV;
>  	}
>  
> -	ret = fdt_fixup_memory_banks(blob, bank_start, bank_size, count);
> -	if (ret)
> -		return ret;
> +	if (blob)
> +		return fdt_fixup_memory_banks(blob, bank_start,
> +					      bank_size, count);
>  
> -	return 0;
> +	return ret;

Please leave this as return 0;

regards,
dan carpenter



More information about the U-Boot mailing list