[PATCH v1 4/4] efi: block: compile only if CONFIG_EFI_PARTITION enabled

[Heinrich Schuchardt]

On 27.02.24 11:04, Alexey Romanov wrote:
> We have to compile efi_block abstraction only if option
> EFI_PARTITION is enabled. For example, if the user
> only enabled MTD_PARTITIONS, we would still compile
> efi_block. This is incorrect.
>
> Signed-off-by: Alexey Romanov <avromanov at salutedevices.com>
> ---
>   lib/efi_driver/Makefile | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/efi_driver/Makefile b/lib/efi_driver/Makefile
> index f2b6c05cc2..1fc85ce6f9 100644
> --- a/lib/efi_driver/Makefile
> +++ b/lib/efi_driver/Makefile
> @@ -6,6 +6,6 @@
>   # object inclusion implicitly depends on it
>
>   obj-y += efi_uclass.o
> -ifeq ($(CONFIG_PARTITIONS),y)
> +ifeq ($(CONFIG_EFI_PARTITION),y)

The symbol CONFIG_EFI_PARTITION is not related to UEFI. It provides
support for GPT partition tables.

efi_block_device.c provides support for block devices provided by EFI
applications. This should not depend on GPT partition table support
(EFI_PARTITION) as it well usable with other partition tables too.

I would not know why iPXE loaded from an MTD block device should not be
able allowed to provide an iSCSI drive.

Please, drop this patch.

Best regards

Heinrich

>   obj-y += efi_block_device.o
>   endif