[PATCH] autoboot: Add check for result of malloc_cache_aligned()

Maks Mishin maks.mishinfz at gmail.com
Thu Feb 29 23:32:11 CET 2024


Return value of a function 'malloc_cache_aligned'
is dereferenced at autoboot.c:207 without checking for NULL,
but it is usually checked for this function.

Found by RASU JSC.

Signed-off-by: Maks Mishin <maks.mishinFZ at gmail.com>
---
 common/autoboot.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/common/autoboot.c b/common/autoboot.c
index 5d331991c1..6f0aeae6bf 100644
--- a/common/autoboot.c
+++ b/common/autoboot.c
@@ -167,6 +167,9 @@ static int passwd_abort_sha256(uint64_t etime)
 		sha_env_str = AUTOBOOT_STOP_STR_SHA256;
 
 	presskey = malloc_cache_aligned(DELAY_STOP_STR_MAX_LENGTH);
+	if (!presskey)
+		return -ENOMEM;
+
 	c = strstr(sha_env_str, ":");
 	if (c && (c - sha_env_str < DELAY_STOP_STR_MAX_LENGTH)) {
 		/* preload presskey with salt */
-- 
2.30.2



More information about the U-Boot mailing list