[PATCH] cmd: sf: Fix sf probe crash

[Michal Simek]

On 1/4/24 12:46, Weizhao Ouyang wrote:
> Handle the return value of spi_flash_probe_bus_cs() to avoid sf probe
> crashes.
> 
> Signed-off-by: Weizhao Ouyang <o451686892 at gmail.com>
> ---
>   cmd/sf.c | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/cmd/sf.c b/cmd/sf.c
> index 730996c02b..e3866899f6 100644
> --- a/cmd/sf.c
> +++ b/cmd/sf.c
> @@ -135,8 +135,9 @@ static int do_spi_flash_probe(int argc, char *const argv[])
>   	}
>   	flash = NULL;
>   	if (use_dt) {
> -		spi_flash_probe_bus_cs(bus, cs, &new);
> -		flash = dev_get_uclass_priv(new);
> +		ret = spi_flash_probe_bus_cs(bus, cs, &new);

if (ret)
	return ret;

don't you want to rather propagate that error?


Thanks,
Michal