[PATCH v6 0/6] Implement fastboot multiresponce

[Svyatoslav Ryhel]

чт, 4 січ. 2024 р. о 17:00 Mattijs Korpershoek <mkorpershoek at baylibre.com> пише:
>
> Hello Svyatoslav,
>
> On jeu., déc. 28, 2023 at 20:01, Svyatoslav Ryhel <clamor95 at gmail.com> wrote:
>
> > Currently u-boot fastboot can only send one message back to host,
> > so if there is a need to print more than one line messages must be
> > kept sending until all the required data is obtained. This behavior
> > can be adjusted using multiresponce ability (getting multiple lines
> > of response) proposed in this patch set.
> >
> > Implementation of multiresponce leads to ability to dump content of
> > console buffer which, with use of "oem run", allows to entirely avoid
> > need in UART.
> >
> > ---
> > Changes in v6:
> >  - remove prev console changes
> >  - add console_record_isempty helper
> >  - set record flag on init
> >
> > Changes in v5:
> >  - restored membuff_readline behavior changed in v4
> >
> > Changes in v4:
> >  - adjust membuff_readline behavior with overflow
> >
> > Changes in v3:
> >  - fix missing function calls if CONFIG_CONSOLE_RECORD is not enabled
> >
> > Changes in v2:
> >  - changed variables to static
> >  - fixed multiresponce for udp
> >  - documented use of "MORE"
> >  - converted #if to if (...)
> > ---
> >
> > Ion Agorria (6):
> >   fastboot: multiresponse support
> >   fastboot: implement "getvar all"
> >   common: console: introduce console_record_isempty helper
> >   common: console: record console from the beginning
> >   lib: membuff: fix readline not returning line in case of overflow
> >   fastboot: add oem console command support
>
> I went on to apply the series, however CI detected a regression in the
> unit tests:
>
> https://source.denx.de/u-boot/custodians/u-boot-dfu/-/jobs/764396
>
> This can be reproduced with:
> $ ./test/py/test.py --bd sandbox --build -k ut_hush_hush_test_simple_dollar
>
> I've narrowed this down to:
>  [PATCH v6 5/6] lib: membuff: fix readline not returning line in case of overflow
>
> Could you please have a look?
>
> Thank you!
>

Test contains 2 skiplines, commenting one fixes test

ut_asserteq(1, run_command("dollar_foo=bar quux\"", 0));
        /* Two next lines contain error message */
        ut_assert_skipline();
        ut_assert_skipline();

> >
> >  boot/bootmeth_extlinux.c          |  2 +-
> >  common/console.c                  | 10 +++-
> >  doc/android/fastboot-protocol.rst |  3 ++
> >  doc/android/fastboot.rst          |  1 +
> >  drivers/fastboot/Kconfig          |  7 +++
> >  drivers/fastboot/fb_command.c     | 52 +++++++++++++++++++++
> >  drivers/fastboot/fb_getvar.c      | 77 +++++++++++++++++++++++++------
> >  drivers/usb/gadget/f_fastboot.c   | 29 ++++++++++++
> >  include/console.h                 | 13 ++++++
> >  include/fastboot-internal.h       |  7 +++
> >  include/fastboot.h                | 19 ++++++++
> >  include/membuff.h                 |  5 +-
> >  lib/membuff.c                     |  4 +-
> >  net/fastboot_udp.c                | 29 +++++++++---
> >  14 files changed, 233 insertions(+), 25 deletions(-)
> >
> > --
> > 2.40.1