[PATCH 1/1] boot: superfluous assignment in bootflow_menu_new()

Heinrich Schuchardt heinrich.schuchardt at canonical.com
Sun Jan 7 10:01:07 CET 2024


ret is assigned a value 0 which is never used but
is immediately overwritten in the next statement.

Addresses-Coverity-ID: 453304 ("Unused value")
Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt at canonical.com>
---
 boot/bootflow_menu.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/boot/bootflow_menu.c b/boot/bootflow_menu.c
index 7c1abe5772..16f9cd8f8c 100644
--- a/boot/bootflow_menu.c
+++ b/boot/bootflow_menu.c
@@ -120,7 +120,6 @@ int bootflow_menu_new(struct expo **expp)
 
 		if (ret < 0)
 			return log_msg_ret("itm", -EINVAL);
-		ret = 0;
 		priv->num_bootflows++;
 	}
 
-- 
2.43.0



More information about the U-Boot mailing list