[PATCH v5 12/12] efi: Correct smbios-table installation

[Simon Glass]

On 1/1/24 01:37, Simon Glass wrote:
> Hi Heinrich,
>
> On Sun, Dec 31, 2023 at 9:27 AM Heinrich Schuchardt <xypron.glpk at gmx.de> wrote:
>>
>> On 12/31/23 16:25, Simon Glass wrote:
>>> At present this code allocates memory when writing the tables and
>>> then unnecessarily adds another memory map when installing it.
>>>
>>> Adjust the code to allocate the tables using the normal U-Boot
>>> mechanism. This avoids doing an EFI memory allocation early in
>>> U-Boot, which may use memory that would be overwritten by a
>>> 'load' command, for example.
>>>
>>> Signed-off-by: Simon Glass <sjg at chromium.org>
>>
>> In patch 11/12 you changed the address fields in ACPI tables from
>> sandbox virtual addresses to pointers. Do you plan to do the same for
>> SMBIOS?
>
> I haven't looked at it, but could if it would help. Are you planning
> to add an EFI test app for sandbox?

Yes, we need a test checking that the SMBIOS protocol is correctly
installed. A tool like dtbdump.efi (lib/efi_loader/dtbdump.efi) would
allow to dump the SMBIOS table to file and then use dmidecode to check
the tables for consistency.

Best regards

Heinrich

Applied to u-boot-dm/next, thanks!