[PATCH 04/10] board: ti: am64x: Set fdtfile from C code instead of findfdt script
Nishanth Menon
nm at ti.com
Tue Jan 9 15:25:32 CET 2024
On 15:08-20240109, Roger Quadros wrote:
[..]
> > #ifdef CONFIG_BOARD_LATE_INIT
> > +static struct ti_fdt_map ti_am64_evm_fdt_map[] = {
> > + {"am64x_gpevm", "k3-am642-evm.dtb"},
> > + {"am64x_skevm", "k3-am642-sk.dtb"},
>
> "am64x_gpevm" and "am64x_skevm" strings are used multiple times in this file.
> see setup_board_eeprom_env()
>
> Please use a MACRO for them.
>
> What is the logic of choosing this name and can it be updated at this point?
> e.g."gp" is misleading in the board name as the boards are now shipped with
> HS-FS chip and are no longer GP.
Intent of the series was to get rid of findfdt - it was not meant to
cleanup existing name usage in the files. If there is a desire to do so,
please - patches are welcome.
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
More information about the U-Boot
mailing list