[PATCH] arm64: xilinx: Move address/size-cells to proper locations

[Krzysztof Kozlowski]

On 11/01/2024 08:09, Michal Simek wrote:
> 
> 
> On 1/10/24 22:27, Krzysztof Kozlowski wrote:
>> On 10/01/2024 14:35, Michal Simek wrote:
>>> Move cells to board dtsi files from generic zynqmp.dtsi. Changes are
>>> related to qspi, spi, nand, i2c and ethernet nodes.
>>>
>>> All errors are generated when dtbs are compiled with W=1.
>>>
>>
>> I don't see any errors on some other platforms, like Samsung. Isn't the
>> actual problem that you do not disable the nodes (I2C, SPI etc) in DTSI?
> 
> On i2c node. Bus is present on the board but it can end in a connector or device 
> which we don't have OS/bootloader drivers for. But we have drivers using i2c 
> tools or u-boot i2c probe. It means that transition should happen.
> On i2c interesting is that W=1 is not able to report issues when you have i2c 
> mux described like this
> 
>                  i2c at 0 {
>                          #address-cells = <1>;
>                          #size-cells = <0>;
>                          reg = <0>;
>                          /* HPC0_IIC */

I understand and it is quite common, but it does not explain the case.
Your bus should still be disabled in DTSI and enabled in DTS for these
cases.

And how exactly do you solve the warning for above case?

>                  };
> 
> and it doesn't report that cells shouldn't be there.
> 
> SPI is pretty much the same story with using spidev.
> 
> Ethernet with mdio. I have converted all phy description to use mdio node 
> because it provides ability to have separate reset for the whole mdio bus and 
> then every phy can also have own reset itself that's why using this type of 
> description is better from flexibility point of view.
> 
> qspi/nand - we have driver for that devices all the time but it doesn't make 
> sense to have some nodes follow some rules and others not.

Best regards,
Krzysztof